feat: option to remove unused cache entries#25
Closed
dreyks wants to merge 1 commit intowebpack:masterfrom
Closed
Conversation
Member
|
It is very degrade performance |
Member
|
Also it is very recommitted disable cache for CI and/or remove cache directory before/after build. |
Member
|
Anyway good work, i need consult with other developers about this, feel free to feedback |
Author
|
is it really a performance degradation? this is run only once at the end of the build. if used constantly there usually won't be many obsolete entries |
Member
|
@dreyks by default it is |
Member
|
@dreyks sorry for delay, not sure we should implement this option, why:
|
|
This would be useful. We are having issues with the terser cache building up over time so we need to manually clear it |
Member
|
@anton164 yep, please remove cache manually, if you have a problem with cache, please open a new issue with reproducible test repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
I'm using terser caches to speed up CI builds. But it turned out that unlike say hard-source plugin terser plugin does not cleanup old obsolete caches. This leads to cache size snowballing and build performance degradation
So I've introduced a new option
compactCachewhich is set tofalseby default. When enabled it will remove all cache entries that were not a part of the current build.That way only one set of caches is retained. This means that if you change your code back and forth you'll get cache misses but since terser is mostly used in production builds only that should not be an issue - reverts to exact same old code are rare
Breaking Changes
Nope
Additional Info