Skip to content

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 16, 2024

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

See original PR #130 for the motivation.

Breaking Changes

Additional Info

Closes #130
Fixes #185
Closes #198
Fixes babel/babel-loader#1043

This PR is based on #130. In this PR we fixed the bug that caused the worker hanging, aligned the less-loader test case with the sass-loader one and incorporated the review comment #185 (comment).

We also bumped babel-loader to 9.2.0, which is also affected by the issue #185.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 16, 2024

CLA Missing ID CLA Not Signed

@codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 19.00%. Comparing base (1bed580) to head (8d39667).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/worker.js 0.00% 44 Missing and 1 partial ⚠️
src/WorkerPool.js 0.00% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   21.23%   19.00%   -2.23%     
==========================================
  Files           8        8              
  Lines         504      563      +59     
  Branches      108      111       +3     
==========================================
  Hits          107      107              
- Misses        348      405      +57     
- Partials       49       51       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait alexander-akait merged commit 158d52b into webpack:master Sep 17, 2024
14 of 17 checks passed
@alexander-akait
Copy link
Member

Thank you

@JLHwung JLHwung deleted the fix-babel-loader-compatibility branch September 17, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants