Fix compilation on Node v10.11 #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Author
|
Just signed |
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
====================================
Coverage 0% 0%
====================================
Files 7 7
Lines 372 372
Branches 66 66
====================================
Misses 325 325
Partials 47 47Continue to review full report at Codecov.
|
kevinburke
commented
Oct 4, 2018
package.json
Outdated
| "eslint-config-webpack": "^1.2.1", | ||
| "eslint-plugin-import": "^2.2.0", | ||
| "extract-text-webpack-plugin": "^3.0.0", | ||
| "fsevents": "^1.2.4", |
Author
There was a problem hiding this comment.
Previously we hadn't depended explicitly on this or nan but I had to specify them to get the right versions installed.
Attempting to run "npm install" on a new-ish Mac with Node v10.11 fails with a number of node-gyp compilation failures. Installing and using the latest versions of node-sass, nan, and fsevents resolves this failure, as each of those packages resolves the issues that led to problems. Update lodash to v4.17.11 to fix a security warning present in the Travis CI configuration. Add Node 10 to the build matrix so we can test for it. I am nervous about the number of changes to package-lock.json and I am not sure how to mitigate that - apparently NPM 6 changed the way requirements are stored in the file so we'll just have to do this at some point. npm/npm#20434
kevinburke
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Oct 5, 2018
The thread-loader package starts several subprocesses. When you send a SIGINT to thread-loader, the subprocesses terminate, but the parent process hangs while waiting for them to send data. We were not listening for the 'end' event in the parent process which meant that the webpack processes would just hang forever. This is a problem because this blocks the shutdown of goreman which means we can have orphan processes and is, in general, a huge hassle when developing the codebase locally. Fix this by listening for an 'end' event, which means we can signal to Webpack that the job terminated with an error, instead of not terminating. This means that SIGINT will actually shut down the process instead of leaving it hanging forever. Fixes sourcegraph/sourcegraph#186. Updates webpack/thread-loader#33. Updates webpack/thread-loader#34. Updates webpack/thread-loader#35. Updates webpack/thread-loader#36.
Collaborator
|
@evilebottnawi I think we can close this PR in favor of #36 as the same changes are being applied in the referenced PR, or we can merge it before merging the referenced one! |
Member
|
Close in favor #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to run "npm install" on a new-ish Mac with Node v10.11
fails with a number of node-gyp compilation failures. Installing and
using the latest versions of node-sass, nan, and fsevents resolves
this failure, as each of those packages resolves the issues that led
to problems.
I am nervous about the number of changes to package-lock.json and I am
not sure how to mitigate that.