Fix lifecycle handling for signals #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=========================================
- Coverage 19.9% 19.3% -0.61%
=========================================
Files 7 7
Lines 432 430 -2
Branches 74 74
=========================================
- Hits 86 83 -3
- Misses 305 306 +1
Partials 41 41
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Jan 10, 2019
|
@evilebottnawi I'm planning to open separate PRs specifically to increase the test coverage and also to refine our architecture! I'll close and merge this for now so we can close the issue and unblock the users 😃 |
|
👍 |
|
Does anyone know when to send a new version containing this pr? @mistic @evilebottnawi |
|
@Dcatfly I believe we are okay to do it early next week 😃 |
|
@mistic let's release new version 👍 |
|
@evilebottnawi @mistic Good~ Thank you for your work~👍😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a problem with handling signals on thread-loader process itself which was resulting on process hang in some situations (like for example using webpack-dev-server from a forked process).
Closes #56
\CC @evilebottnawi