Support splitting of files and directories in getTimeInfoEntries#205
Support splitting of files and directories in getTimeInfoEntries#205sokra merged 3 commits intowebpack:mainfrom
Conversation
|
Azure Pipelines tests all pass, but need permissions for Travis-CI |
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 91.38% 92.80% +1.41%
==========================================
Files 6 6
Lines 1068 1014 -54
Branches 257 239 -18
==========================================
- Hits 976 941 -35
+ Misses 92 73 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thanks @vankop for queuing - I foolishly left an |
avoid deeply collecting watchers since they are always collected during time collection add existence file time info for directories fix safeTime collection
|
Thanks |
Supports the splitting of
getTimeInfoEntriesbetween files and directories.This supports both old and new functionality:
As a small note, the caching present in old mechanism is removed. From my investigation, it doesnt actually block out much computation (since we still need to do the map merging one recursion-level up). The caching also would not provide any benefit in the new mechanism, as we need to do the same number of map additions regardless.
Given these changes, we can incorporate into webpack by changing using the new map-passing pattern here. I have those changes all ready to go, and all webpack-side watching tests are passing with my linked version of these changes.
https://github.com/webpack/webpack/blob/c181294865dca01b28e6e316636fef5f2aad4eb6/lib/node/NodeWatchFileSystem.js#L81