Fix assets without name causing analyze failure#386
Merged
th0r merged 3 commits intowebpack:masterfrom Nov 7, 2020
Merged
Conversation
|
|
Member
|
Can you add a test case and a changelog entry? |
Contributor
Author
|
@valscion |
Contributor
Author
|
@valscion |
Member
|
Yeah this looks good to me — would @th0r want to take a look as you originally asked for a new PR here? #385 (comment) |
th0r
requested changes
Nov 6, 2020
ZKHelloworld
force-pushed
the
fix-no-name-asset
branch
from
22ca70e to
fa53704
Compare
Collaborator
|
Could you also merge latest |
ZKHelloworld
force-pushed
the
fix-no-name-asset
branch
from
fa53704 to
7ff0fbb
Compare
ZKHelloworld
force-pushed
the
fix-no-name-asset
branch
from
7ff0fbb to
493c30c
Compare
Contributor
Author
Done. |
th0r
approved these changes
Nov 7, 2020
Collaborator
|
Thanks! |
Member
|
Released in v4.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this issue #385