refactor: more ES6 code and code improvements#700
Merged
Conversation
Member
Author
|
@valscion Ready for review It is a part of refactor tasks and many changes done to avoid big diff after migration to |
valscion
approved these changes
Jan 30, 2026
Member
valscion
left a comment
There was a problem hiding this comment.
Phew that was a lot of code changes to read but I did read all of that.
Only found one nitpick. Let's fix it and then we can merge
src/utils.js
Outdated
| /** | ||
| * @desc get string of current time | ||
| * format: dd/MMM HH:mm | ||
| * */ |
Member
Author
|
@valscion Done 👍 |
valscion
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor core:
node:prefix for NodeJS modules (good practice, compatibility with deno/bun/other env)js/jsxextensions forimport(good practice, less time for resolving in any tools, nodejs/typescript/react/etc strongly recommend to use extensions inimports)for ofinsteadforEach(for ofis faster)hasOwnbuilt-in ES6 featuremodule.exportsat the bottom of files for readablecatchwithout_errwhere we don't need itelsewhere it unnecessary{for multi-lineifWhat kind of change does this PR introduce?
refactor
Did you add tests for your changes?
Existing
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing