support webpack v4 #264
Closed
support webpack v4 #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade to new tapable hooks API
|
|
Contributor
|
@mattkrick thanks for the PR, but you'll need to restore the PR template and properly fill in the details before we can review this. also looks like you have a failure in Travis CI you'll have to fix to move forward. |
2 tasks
Member
|
@mattkrick friendly ping |
|
Something to mention about Previously: Watching {
startTime: 1519735902177,With webpack 4: Compiler {
_pluginCompat: |
Contributor
|
Fucking A - I absolutely loathe how little documentation there is for this release. Thanks for the heads up @pi0 🍺 |
gpoitch
reviewed
Feb 28, 2018
| context.rebuild = rebuild; | ||
| context.compiler.plugin('invalid', invalid); | ||
| context.compiler.plugin('run', invalid); | ||
| context.compiler.hooks.invalid.tap({name: 'CopyPlugin'}, invalid) |
Contributor
There was a problem hiding this comment.
I believe all the names should be 'webpack-dev-middleware', not 'CopyPlugin'
Contributor
|
Since the OP closed this, we'll be putting together a major release today for webpack@4 support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade to new tapable hooks API
Summary
deprecation warnings appear if using the old API
Does this PR introduce a breaking change?
yes,webpack v4 only