chore(travis): update the node_js version on travis config #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLarkInn
commented
Sep 15, 2016
| node_js: | ||
| - 6 | ||
|
|
||
| - "6" |
There was a problem hiding this comment.
@bebraw I noticed on the official documentation for travis that they were using the version numbers as strings. Do I think this makes a difference, I am not 100% sure. But it appears that the tests are running against v6 now.
There was a problem hiding this comment.
Yeah, merged as string is better style.
sallar
pushed a commit
to sallar/webpack.js.org
that referenced
this pull request
Oct 19, 2016
…node_version_to_6 chore(travis): update the node_js version on travis config
hzuhyb
pushed a commit
to hzuhyb/webpack.js.org
that referenced
this pull request
Feb 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was noticing that all recent travis builds were still running against node 4 as the config. Am curious if this is related to the invariant issues. Going to try this out.