docs: improve docs #2891
Merged
docs: improve docs #2891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneHlushko
requested changes
Mar 22, 2019
Member
EugeneHlushko
left a comment
EugeneHlushko
left a comment
There was a problem hiding this comment.
Need another grammar expert for bits under question
Contributor
Author
wizardofhogwarts
left a comment
wizardofhogwarts
left a comment
There was a problem hiding this comment.
@EugeneHlushko Please review the comments and suggestion.
rishabh3112
suggested changes
Mar 26, 2019
Member
rishabh3112
left a comment
rishabh3112
left a comment
There was a problem hiding this comment.
@wizardofhogwarts added some suggestions.
cc @EugeneHlushko
ya this makes sense Thanks @rishabh3112 Co-Authored-By: wizardofhogwarts <48159922+wizardofhogwarts@users.noreply.github.com>
@rishabh3112 ok Co-Authored-By: wizardofhogwarts <48159922+wizardofhogwarts@users.noreply.github.com>
Contributor
Author
|
@rishabh3112 @EugeneHlushko @montogeek Please review. Any other changes required? |
yaaooo
reviewed
Mar 31, 2019
Contributor
yaaooo
left a comment
yaaooo
left a comment
There was a problem hiding this comment.
Native English speaker here (🇸🇬 + 🇺🇸), some comments
cc @EugeneHlushko
Member
|
@wizardofhogwarts please see @superburrito comments |
Co-Authored-By: wizardofhogwarts <48159922+wizardofhogwarts@users.noreply.github.com>
Contributor
Author
Seen and implemented two of the suggested changes. |
EugeneHlushko
approved these changes
Apr 8, 2019
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.