fix(docs): Update development-vagrant.mdx #5365
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/4FAm54iPomJUMfUMAvAkxf621DLP |
pepies
changed the title
|
|
||
| ```bash | ||
| webpack serve --public 10.10.10.61 --watch-poll | ||
| webpack serve --client-web-socket-url 10.10.10.61 --watch-poll |
Member
There was a problem hiding this comment.
ideally it should be wss://hostname:port/ws, because it is full url
snitin315
reviewed
Aug 25, 2021
|
|
||
| ```bash | ||
| webpack serve --host 0.0.0.0 --public 10.10.10.61:8080 --watch-poll | ||
| webpack serve --host 0.0.0.0 --client-web-socket-url 10.10.10.61:8080 --watch-poll |
Member
There was a problem hiding this comment.
Also, I think we need to update --watch-poll to --watch-options-poll everywhere.
Suggested change
| webpack serve --host 0.0.0.0 --client-web-socket-url 10.10.10.61:8080 --watch-poll | |
| webpack serve --host 0.0.0.0 --client-web-socket-url 10.10.10.61:8080 --watch-options-poll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this:
https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md
public, sockHost, sockPath, and sockPort options were removed in favor client.webSocketURL
Webpack version 5 installs dev server version 4 by default so documentation should be in sync with newest stable release.