-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(docs): Update development-vagrant.mdx #5365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,13 +56,13 @@ Note that you also need to create an `app.js` file. | |
| Now, let's run the server: | ||
|
|
||
| ```bash | ||
| webpack serve --host 0.0.0.0 --public 10.10.10.61:8080 --watch-poll | ||
| webpack serve --host 0.0.0.0 --client-web-socket-url 10.10.10.61:8080 --watch-poll | ||
| ``` | ||
|
|
||
| By default, the server will only be accessible from localhost. We'll be accessing it from our host PC, so we need to change `--host` to allow this. | ||
|
|
||
| `webpack-dev-server` will include a script in your bundle that connects to a WebSocket to reload when a change in any of your files occurs. | ||
| The `--public` flag makes sure the script knows where to look for the WebSocket. The server will use port `8080` by default, so we should also specify that here. | ||
| The `--client-web-socket-url` flag makes sure the script knows where to look for the WebSocket. The server will use port `8080` by default, so we should also specify that here. | ||
|
|
||
| `--watch-poll` makes sure that webpack can detect changes in your files. By default, webpack listens to events triggered by the filesystem, but VirtualBox has many problems with this. | ||
|
|
||
|
|
@@ -96,7 +96,7 @@ The `proxy_set_header` lines are important, because they allow the WebSockets to | |
| The command to start `webpack-dev-server` can then be changed to this: | ||
|
|
||
| ```bash | ||
| webpack serve --public 10.10.10.61 --watch-poll | ||
| webpack serve --client-web-socket-url 10.10.10.61 --watch-poll | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ideally it should be |
||
| ``` | ||
|
|
||
| This makes the server only accessible on `127.0.0.1`, which is fine because nginx takes care of making it available on your host PC. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think we need to update
--watch-pollto--watch-options-polleverywhere.