Fix missing quotes in CSS <link> tags and refactor redundant template#7993#7994
Merged
alexander-akait merged 1 commit intowebpack:mainfrom Mar 12, 2026
Merged
Fix missing quotes in CSS <link> tags and refactor redundant template#7993#7994alexander-akait merged 1 commit intowebpack:mainfrom
alexander-akait merged 1 commit intowebpack:mainfrom
Conversation
alexander-akait
approved these changes
Mar 12, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue closes: #7993
This PR fixes a syntax issue in the SSG (Server-Side Generation) script where CSS
<link>tags were being generated with unquotedhrefattributes. While most browsers handle unquoted attributes gracefully, it can lead to parsing errors if asset paths contain special characters or spaces.Additionally, this PR simplifies the mapping logic by removing redundant template literal nesting (
${path}) in favor of a cleaner string interpolation.What kind of change does this PR introduce?
Bug fix (Fixing invalid HTML syntax)
Code cleanup (Refactoring redundant template literals)
Did you add tests for your changes?
No, as this is a minor syntax adjustment to a template literal within the HTML
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A
Use of AI
GitHub Copilot