feat: consider asset module as side-effect-free

[hai-x]

Summary

What kind of change does this PR introduce?

Fixes part of #20209.

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

Theoretically not

If relevant, what needs to be documented once your changes are merged or what have you already documented?

No

[changeset-bot]

🦋 Changeset detected

Latest commit: 288c500

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
webpack	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

This PR is packaged and the instant preview is available (5ecc58d).

Install it locally:

• npm

npm i -D webpack@https://pkg.pr.new/webpack@5ecc58d

• yarn

yarn add -D webpack@https://pkg.pr.new/webpack@5ecc58d

• pnpm

pnpm add -D webpack@https://pkg.pr.new/webpack@5ecc58d

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing asset-side-effect-free (288c500) with main (fe48655)¹}

Summary

✅ 72 untouched benchmarks

Footnotes

1. No successful run was found on main (cd4793d) during the generation of this report, so fe48655 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[alexander-akait]

Looks like we need to fix tests, but code looks good

[hai-x]

We should consider a better approach for setting factoryMeta. It is assigned at parsing stage right now, it will lead to some issue when working with both disk and memory caching, and cause module.factoryMeta can't be properly restored.

[alexander-akait]

@hai-x Yeah, we have the same problem with renaming modules, alternative solution - make builtMeta and buildInfo as getters, but will be glad to have a hook to setup it

[hai-x]

I use createModuleClass here cause it will be called at the factory stage. And it also aligns with our goal of creating asset modules via newly AssetModule(it's still TODO).

[alexander-akait]

What about to rewrite test to see that unused module was removed, we have __webpack_modules__ to check them in chunk

[hai-x]

Thanks for review. It such one good idea to use __webpack_modules__.