Skip to content

Encode the collection sharing URL #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

Encode the collection sharing URL #1362

merged 1 commit into from
Nov 9, 2023

Conversation

@Shrinks99
Copy link
Collaborator

closes #1357

Changes

  • Encodes the collection sharing URL available in the Link to Share section of the collection sharing dialog

Before

https://replayweb.page?source=http://localhost:9870/api/orgs/c69247f4-415e-4abc-b449-e85d2f26c626/collections/0795d95f-a058-4dd2-b858-3624d3281e4b/public/replay.json

After:

https://replayweb.page?source=http%3A%2F%2Flocalhost%3A9870%2Fapi%2Forgs%2Fc69247f4-415e-4abc-b449-e85d2f26c626%2Fcollections%2F0795d95f-a058-4dd2-b858-3624d3281e4b%2Fpublic%2Freplay.json

@Shrinks99
Encode the sharing URL
1022149 
- Leaves the embed code URL not encoded
@Shrinks99 Shrinks99 self-assigned this Nov 9, 2023
emma-sg
emma-sg approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

tw4l
tw4l approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shrinks99 Shrinks99 merged commit a71815a into main Nov 9, 2023
@Shrinks99 Shrinks99 deleted the frontend-encode-sharing-url branch November 9, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikreymer ikreymer ikreymer approved these changes

@emma-sg emma-sg emma-sg approved these changes

@tw4l tw4l tw4l approved these changes

Assignees

@Shrinks99 Shrinks99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: URL encode source url in shared collection URLs

5 participants

@Shrinks99 @ikreymer @emma-sg @tw4l