Refactor collections and browser profile data-tables #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
changed the base branch from
main
to
frontend-checkbox-list--crawl-list
3 tasks
SuaYoo
force-pushed
the
frontend-use-data-tables
branch
2 times, most recently
from
2b60629 to
e4b31b6
Compare
SuaYoo
force-pushed
the
frontend-use-data-tables
branch
from
e4b31b6 to
2ee2888
Compare
ikreymer
approved these changes
Jan 31, 2024
Shrinks99
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1483
@Shrinks99 while we're still settling on data table variations, I added a shadow to collection and browser profile items to match workflows more for now.
Changes
Manual testing
Screenshots