Fixes workflow selector keyboard navigation #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes from `<div>`s to `<button>`s so that these can be selected with tab and enter. - Adds tabindex for correct selection of items - Removes the H3, combines with window title
Shrinks99
added
bug
|
Tested keyboard nav, appears to be working, nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1387
Context
While checking some other keyboard navigation issues, I found that I was unable to create a crawl workflow using only keyboard navigation. This PR fixes that!
Changes
<div>s to<button>s so that these can be selected with tab and enter.Screenshots
Before — Image not loaded VS loaded
After — Both images loaded, URL list focused!
Image not loaded VS loaded
