Skip to content

Fix browser profile launch by specifying relative path inside oid dir to profilejob #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
Merged

Fix browser profile launch by specifying relative path inside oid dir to profilejob #2912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dd034f
Use relative filepath inside oid dir for profiles
tw4l Oct 21, 2025
61c5676
Add profile to crawl already being used in tests
tw4l Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/btrixcloud/profiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,7 @@ async def get_profile_storage_path_and_proxy(
try:
profile = await self.get_profile(profileid, org)
storage_path = profile.resource.filename if profile.resource else ""
storage_path = storage_path.lstrip(f"{org.id}/")
return storage_path, profile.proxyId or ""
# pylint: disable=bare-except
except:
Expand Down
3 changes: 2 additions & 1 deletion backend/test/test_run_crawl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def test_create_new_config(admin_auth_headers, default_org_id):
assert data["storageQuotaReached"] is False


def test_start_crawl(admin_auth_headers, default_org_id):
def test_start_crawl(admin_auth_headers, default_org_id, profile_id):
# Start crawl.
crawl_data = {
"runNow": True,
Expand All @@ -77,6 +77,7 @@ def test_start_crawl(admin_auth_headers, default_org_id):
# limit now set via 'max_pages_per_crawl' global limit
# "limit": 1,
},
"profileid": profile_id,
}
r = requests.post(
f"{API_PREFIX}/orgs/{default_org_id}/crawlconfigs/",
Expand Down
Loading