Skip to content

Conversation

@tw4l
Copy link
Member

@tw4l tw4l commented Oct 21, 2025

Fixes #2911

Follow-up to #2891

This commit strips the oid prefix from the profile filename before passing it along to the profilejob so that it's in the format the crawler expects.

I've also added a profile to an existing test that runs a crawl and verifies that state is complete at finished (i.e. not failed) to catch any similar type regression in the future.

Testing

  • Spin up a local instance of Browsertrix
  • Verify you can now spin up profile browsers
  • Run nightly test that actually launches a profile browser: python -m pytest backend/test_nightly/test_crawl_not_logged_in.py

@tw4l tw4l requested a review from ikreymer October 21, 2025 15:57
Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Waiting for the nightly test to run on this branch to ensure that's also fixed.

@ikreymer ikreymer self-requested a review October 21, 2025 19:27
@ikreymer ikreymer merged commit 89b1c5e into main Oct 21, 2025
80 of 84 checks passed
@ikreymer ikreymer deleted the issue-2911-browser-profile branch October 21, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Browser profiles not launching after profile filename changes

3 participants