Skip to content

Conversation

@SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Nov 13, 2025

Resolves #2959
Resolves #2964

Changes

  • Updates browser profile dialogs to organize settings into separate "Crawler Settings" section
  • Allows users to replace saved sites with new site
  • Fixes browser site list loading state
  • Consistently displays profile URLs

Manual testing

  1. Log in as crawler to org with proxies
  2. Go to browser profiles list
  3. Select "New Browser Profile". Verify additional crawler settings are in a separate section
  4. Select a browser profile
  5. Select "Add Site"
  6. Check "Replace saved sites". Verify proxy setting is shown under "Crawler Settings"
  7. Start browser
  8. Save. Verify previously configured sites have been replaced.

Screenshots

See #2986 (comment)

@SuaYoo SuaYoo marked this pull request as ready for review November 18, 2025 18:50
@SuaYoo SuaYoo changed the title wip: Allow users to replace profile browser feat: Allow users to replace profile browser Nov 18, 2025
@SuaYoo SuaYoo requested review from emma-sg, ikreymer and tw4l November 18, 2025 18:51
@ikreymer
Copy link
Member

ikreymer commented Nov 18, 2025

Looks great!
One small bug:

  • Changing the Crawler Channel dropdown does not update the version string (only actual issue i think).

Text things:

  • When there is only one URL, the Configure New Site doesn't show the dropdown - just a single URL, I guess that's fine, but could be slightly confusing.
  • Should 'Add Site' be renamed 'Load URL' as discussed? Could also show the dropdown in this version of dialog to be consistent, and just label it 'Load URL'. But no strong preference per se. Perhaps the distinction between Add/Load is subtle - the site only gets 'added' once profile is saved and only if there if it's a new origin, but any URL can be loaded.

@SuaYoo
Copy link
Member Author

SuaYoo commented Nov 18, 2025

Changing the Crawler Channel dropdown does not update the version string (only actual issue i think).

Fixed!

When there is only one URL, the Configure New Site doesn't show the dropdown - just a single URL, I guess that's fine, but could be slightly confusing.

Updated to always show the dropdown and input field for the page URL to load.

I named the dropdown "Primary Site" since the URL to load does impact the order of the origins list and browser profile list sorting, which can be sorted by the first origin in the list. I named this "Primary" instead of "First"/"Starting" or similar since we want to encourage users to have a single site per browser profile.

Browser profile list sort:
Screenshot 2025-11-18 at 3 12 05 PM

Configure profile:
Screenshot 2025-11-18 at 3 14 30 PM

Should 'Add Site' be renamed 'Load URL' as discussed? Could also show the dropdown in this version of dialog to be consistent, and just label it 'Load URL'. But no strong preference per se. Perhaps the distinction between Add/Load is subtle - the site only gets 'added' once profile is saved and only if there if it's a new origin, but any URL can be loaded.

I renamed "Configure Profile" in the action menu to "Load Profile" for consistency:
Screenshot 2025-11-18 at 3 17 36 PM

I renamed "Add" to "Load New URL". This opens the same dialog as "Load Profile", but with "New Site" pre-selected.
Screenshot 2025-11-18 at 3 13 36 PM

Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested various options for resetting, new layout makes sense.

@SuaYoo SuaYoo merged commit 2313818 into frontend-browser-profile-ui-enhancements Nov 19, 2025
29 checks passed
@SuaYoo SuaYoo deleted the frontend-browser-profile-ui-enhancements--reset-profile branch November 19, 2025 18:45
SuaYoo added a commit that referenced this pull request Nov 24, 2025
- Updates browser profile dialogs to organize settings into separate
"Crawler Settings" section
- Allows users to replace saved sites with new site
- Fixes browser site list loading state
- Consistently displays profile URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants