Skip to content

fix: Handle no origins or invalid origin #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 27, 2025
Merged

fix: Handle no origins or invalid origin #3025

merged 5 commits into from
Nov 27, 2025

Conversation

@SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Nov 27, 2025 •
edited
Loading

Changes

  • Fixes edge case where profile without valid origin can be saved
  • Handles edge case of no saved sites, since backend does not currently prevent saving profiles without any origins

Manual testing

  1. Log in as crawler
  2. Go to "Browser Profiles" and choose "New Browser Profile"
  3. Enter URL to a site that doesn't exist
  4. Choose "Start Browser"
  5. Wait for browser to load. Verify "Save" button is disabled

Screenshots

Page Image/video
Browser profile Screenshot 2025-11-26 at 4 58 55 PM

@SuaYoo SuaYoo requested review from emma-sg and ikreymer November 27, 2025 01:35
@SuaYoo SuaYoo changed the title fix: Handle no origins fix: Handle no origins or invalid origin Nov 27, 2025
@SuaYoo SuaYoo merged commit 937a563 into frontend-browser-profile-ui-enhancements Nov 27, 2025
29 checks passed
@SuaYoo SuaYoo deleted the frontend-browser-profile-ui-enhancements--no-origins branch November 27, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikreymer ikreymer ikreymer approved these changes

@emma-sg emma-sg Awaiting requested review from emma-sg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuaYoo @ikreymer