Skip to content

Frontend browser profile UI enhancements origin check fix #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2025
Merged

Frontend browser profile UI enhancements origin check fix #3030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c88f81d
fix checking when browser is complete:
ikreymer Nov 27, 2025
dd26574
fix event not firing unless previous task value was set
ikreymer Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions frontend/src/features/browser-profiles/profile-browser-dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ enum BrowserStatus {
Initial,
Pending,
Ready,
Complete,
Error,
}

Expand All @@ -54,6 +53,9 @@ export class ProfileBrowserDialog extends BtrixElement {
@state()
private browserStatus = BrowserStatus.Initial;

@state()
private originsLoaded = false;

@state()
private showConfirmation = false;

Expand Down Expand Up @@ -151,7 +153,8 @@ export class ProfileBrowserDialog extends BtrixElement {
render() {
const isCrawler = this.appState.isCrawler;
const creatingNew = this.duplicating || !this.profile;
const incomplete = this.browserStatus !== BrowserStatus.Complete;
const incomplete =
!this.originsLoaded || this.browserStatus !== BrowserStatus.Ready;
const saving = this.saveProfileTask.status === TaskStatus.PENDING;

return html`<btrix-dialog
Expand Down Expand Up @@ -341,7 +344,7 @@ export class ProfileBrowserDialog extends BtrixElement {
e: CustomEvent<BrowserOriginsChange>,
) => {
if (e.detail.origins.length) {
this.browserStatus = BrowserStatus.Complete;
this.originsLoaded = true;
}
};

Expand Down
6 changes: 1 addition & 5 deletions frontend/src/features/browser-profiles/profile-browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,7 @@ export class ProfileBrowser extends BtrixElement {
try {
const { origins } = await this.pingBrowser(browser.id, signal);

if (
this.originsTask.value &&
origins &&
isNotEqual(this.originsTask.value, origins)
) {
if (origins && isNotEqual(this.originsTask.value, origins)) {
this.dispatchEvent(
new CustomEvent<BrowserOriginsChange>(
"btrix-browser-origins-change",
Expand Down
Loading