Skip to content

Compute crawl config name from seed URLs #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2023
Merged

Compute crawl config name from seed URLs #435

merged 2 commits into from
Jan 3, 2023

Conversation

@SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jan 2, 2023 •
edited
Loading

Resolves #431.

Manual testing

  1. Run app yarn start
  2. Go to new crawl config page. Click "URL List".
  3. Enter URLs and go through flow by clicking "Next" and then save. Verify that default name saves as expected.
  4. Start new URL List crawl config flow again. Enter URLs and click "Confirm & Save" without clicking "Next" and then save. Verify default name saves as expected.
  5. Go to crawl config edit view. Verify name shows in "Crawl Information" section as expected.

Screenshots

"Crawl Information" tab for new URL List config:
Screen Shot 2023-01-02 at 11 51 03 AM

@SuaYoo SuaYoo requested a review from ikreymer January 2, 2023 19:52
@SuaYoo SuaYoo marked this pull request as ready for review January 2, 2023 19:53
@SuaYoo SuaYoo merged commit d33d5f7 into main Jan 3, 2023
@SuaYoo SuaYoo deleted the frontend-compute-crawl-config-name branch January 3, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikreymer ikreymer ikreymer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crawl Configuration: Move Name & Tags back to Crawl Information page

3 participants

@SuaYoo @ikreymer