Skip to content

Crawl config frontend fixes #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 17, 2023
Merged

Crawl config frontend fixes #482

merged 7 commits into from
Jan 17, 2023

Conversation

@SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jan 16, 2023

@SuaYoo SuaYoo requested review from Shrinks99 and ikreymer January 16, 2023 18:03
Shrinks99
Shrinks99 reviewed Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the confirm page exclusion list the bottom border is missing on page 2 and beyond. Page 1 looks as expected. Also on navigating to that page the exclusion list pagination (which is good to have on the confirm page) is set to the last page instead of the first.

Screenshot 2023-01-16 at 1 36 34 PM

@SuaYoo SuaYoo requested a review from Shrinks99 January 16, 2023 19:26
Shrinks99
Shrinks99 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great :D

@ikreymer ikreymer merged commit d324281 into main Jan 17, 2023
tw4l pushed a commit that referenced this pull request Jan 17, 2023
@SuaYoo @tw4l
Crawl config frontend fixes (#482)
47ee64f 
* fix current time limit (#480)
* fix browser profile name not shown (#474)
* fix finish setup button label (#473)
* fix paginated exclusion, border and page size (#475)
@ikreymer ikreymer deleted the frontend-crawl-config-edit-fixes branch February 8, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikreymer ikreymer Awaiting requested review from ikreymer

1 more reviewer

@Shrinks99 Shrinks99 Shrinks99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@SuaYoo @Shrinks99 @ikreymer