Fix localization build #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally and it's working great, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487 by adding double quotes in html nested in
msg(limitation doesn't seem to be documented by lit, only found this out by through the@lit/localize-toolssource code, may be lit bug?)Also, removed the generated translation files from git and instead added npm script to build files before
yarn buildandyarn start. Once we get start internationalization with translating files we could commit xliff files in this repo or a separate repo, this is more to validate thatmsg()s in the build won't throw an error down the road.Manual testing
Run
yarn localize:prepare. Verify that command succeeds withen-US message {message warning} is missing, using canonical text as fallbackwarning, which is expected since we don't have actual translations.