- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 60
 
Crawl config form panel UX enhancement & fix #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           When navigating the form with the  Other than that this is good to go!  | 
    
2d419be    to
    176bc5a      
    Compare
  
    | 
           Updated to remove the checkmark state in the new crawl config flow. Kept it in the edit view (without making them green), since the checkmarks were always shown there anyway.  | 
    
| 
           Now that the steps aren't disabled, can we set iconProps circle "text-neutral-400" instead of 300 to communicate that the step is enabled? The progress indicator bar now operates as only a step indicator. This may have been a miscommunication on my part. I still think it should start from the topmost step and extend downward as it did previously so that it communicates a completion % as users progress toward the end of the process. This will be in line with how we will use it on browser profile setup — though parts of that form will be enforced.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good!

Enables all crawl config steps by default and fixes error icon not synced with form. Also, entering a name is no longer required since it'll be computed by default either when the URL is entered or the config is saved, and checkmarks are only shown as the default state when editing a form.
Manual testing
Demo
Screen.Recording.2023-01-17.at.10.47.43.AM.mov
Screenshots
Name field now optional:
