Skip to content

Conversation

@SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jan 17, 2023

Enables all crawl config steps by default and fixes error icon not synced with form. Also, entering a name is no longer required since it'll be computed by default either when the URL is entered or the config is saved, and checkmarks are only shown as the default state when editing a form.

Manual testing

  1. Go to "New Crawl Config" view. Verify all form sections are navigable
  2. Click navigation on left without entering a seed URL. Verify "Crawl Setup" navigation button shows error icon.
  3. Enter a seed URL. Verify error icon is replaced

Demo

Screen.Recording.2023-01-17.at.10.47.43.AM.mov

Screenshots

Name field now optional:
Screen Shot 2023-01-16 at 6 19 02 PM

@SuaYoo SuaYoo requested review from Shrinks99 and ikreymer January 17, 2023 02:19
@Shrinks99
Copy link
Collaborator

Shrinks99 commented Jan 17, 2023

When navigating the form with the Next Step buttons everything works as expected! Now that this form has become slightly less linear, lets remove the green checkmark state for now as per discussion in chat.

Other than that this is good to go!

@SuaYoo SuaYoo marked this pull request as draft January 17, 2023 17:26
@SuaYoo SuaYoo force-pushed the frontend-crawl-config-step-enhancements branch from 2d419be to 176bc5a Compare January 17, 2023 17:42
@SuaYoo SuaYoo marked this pull request as ready for review January 17, 2023 18:49
@SuaYoo
Copy link
Member Author

SuaYoo commented Jan 17, 2023

Updated to remove the checkmark state in the new crawl config flow. Kept it in the edit view (without making them green), since the checkmarks were always shown there anyway.

@Shrinks99
Copy link
Collaborator

Shrinks99 commented Jan 17, 2023

Now that the steps aren't disabled, can we set iconProps circle "text-neutral-400" instead of 300 to communicate that the step is enabled?

Screenshot 2023-01-17 at 5 33 42 PM

The progress indicator bar now operates as only a step indicator. This may have been a miscommunication on my part. I still think it should start from the topmost step and extend downward as it did previously so that it communicates a completion % as users progress toward the end of the process. This will be in line with how we will use it on browser profile setup — though parts of that form will be enforced.

@SuaYoo SuaYoo merged commit ebb634a into main Jan 18, 2023
Copy link
Collaborator

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good!

@SuaYoo SuaYoo deleted the frontend-crawl-config-step-enhancements branch January 18, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Form validation error icon appearing after validation has succeeded Enable all crawl config pages

4 participants