Refactor scheduler/todo runner onto shared process-runner core#109
Merged
charlesrhoward merged 1 commit intomainfrom Feb 16, 2026
Merged
Refactor scheduler/todo runner onto shared process-runner core#109charlesrhoward merged 1 commit intomainfrom
charlesrhoward merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add a shared main-process runner utility for spawn lifecycle, timeout, force-kill, stdout parsing, and tail capture\n- migrate scheduler task execution to the shared runner while preserving status/error logging semantics\n- migrate todo-runner execution to the shared runner while preserving payload transport and retry behavior\n\n## Validation\n- pnpm run lint:desktop\n- pnpm run typecheck\n- pnpm exec playwright test -c playwright.smoke.config.ts --workers=1\n\nCloses #97
Note
Medium Risk
Moderate refactor of main-process child-process lifecycle (spawn, timeouts, kill signaling, and output parsing) for scheduler/todo execution; behavior should be equivalent but subtle timing/error-handling differences could affect job completion and status reporting.
Overview
Introduces a new shared
process-runnerutility that centralizes child-process spawning, stdin payload writing, stdout line handling, stderr/stdout tail capture, runtime timeouts (SIGTERM then SIGKILL), and force-kill timer management.Refactors both
schedulerandtodo-runnerto userunManagedProcessplus shared helpers for env-based runtime config and force-kill scheduling, replacing bespoke per-module timers/readline/stdio logic while preserving existing logging/events and error/status derivation (including todo-runner’s payload-transport spawn error handling and retry/pause behavior).Written by Cursor Bugbot for commit e491411. This will update automatically on new commits. Configure here.