ci: run Electron smoke tests on pull requests#72
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35411a60f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| exit 0 | ||
| fi | ||
|
|
||
| changed_files="$(git diff --name-only "$BASE_SHA" "$HEAD_SHA")" |
There was a problem hiding this comment.
Diff PR changes from merge base, not base tip
git diff --name-only "$BASE_SHA" "$HEAD_SHA" compares the two tip snapshots, so on PRs where main has advanced since the branch point it will include files changed only on main (for example under src/), causing should_run=true even when the PR itself only touches unrelated files. This breaks the new cost-control behavior for pull requests; use a merge-base comparison (... or --merge-base) to scope to files introduced by the PR branch.
Useful? React with 👍 / 👎.
Summary
Closes #61
Note
Low Risk
CI-only change that gates when a macOS smoke job runs; main risk is accidentally skipping smoke coverage due to incorrect path matching or diff SHAs.
Overview
Adds a new
smoke-scopejob to decide whether Electron smoke tests should run by diffing PR base/head commits and checking for changes in smoke-critical paths.Updates
smoke-desktopto run on PRs whensmoke-scopesays to (and still always onpush), gating the macOS workflow cost while preserving coverage for relevant changes.Written by Cursor Bugbot for commit 35411a6. This will update automatically on new commits. Configure here.