Skip to content

ci: run Electron smoke tests on pull requests#72

Merged
charlesrhoward merged 1 commit intomainfrom
codex/fix-61-smoke-on-pr
Feb 16, 2026
Merged

ci: run Electron smoke tests on pull requests#72
charlesrhoward merged 1 commit intomainfrom
codex/fix-61-smoke-on-pr

Conversation

@charlesrhoward
Copy link
Copy Markdown
Contributor

@charlesrhoward charlesrhoward commented Feb 16, 2026

Summary

  • add a lightweight smoke-scope job that decides when smoke should run
  • run desktop smoke for all pushes and for pull requests that touch desktop/smoke-critical paths
  • keep macOS smoke cost controlled by skipping PRs that only change unrelated files

Closes #61


Note

Low Risk
CI-only change that gates when a macOS smoke job runs; main risk is accidentally skipping smoke coverage due to incorrect path matching or diff SHAs.

Overview
Adds a new smoke-scope job to decide whether Electron smoke tests should run by diffing PR base/head commits and checking for changes in smoke-critical paths.

Updates smoke-desktop to run on PRs when smoke-scope says to (and still always on push), gating the macOS workflow cost while preserving coverage for relevant changes.

Written by Cursor Bugbot for commit 35411a6. This will update automatically on new commits. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agent-space-web Ready Ready Preview, Comment Feb 16, 2026 2:16am

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35411a60f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
exit 0
fi

changed_files="$(git diff --name-only "$BASE_SHA" "$HEAD_SHA")"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Diff PR changes from merge base, not base tip

git diff --name-only "$BASE_SHA" "$HEAD_SHA" compares the two tip snapshots, so on PRs where main has advanced since the branch point it will include files changed only on main (for example under src/), causing should_run=true even when the PR itself only touches unrelated files. This breaks the new cost-control behavior for pull requests; use a merge-base comparison (... or --merge-base) to scope to files introduced by the PR branch.

Useful? React with 👍 / 👎.

@charlesrhoward charlesrhoward merged commit b26ea4e into main Feb 16, 2026
7 checks passed
@charlesrhoward charlesrhoward deleted the codex/fix-61-smoke-on-pr branch February 16, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Electron smoke tests on pull requests, not only pushes

1 participant