Fix/eager loading with after select and orderby#60
Merged
benkhalife merged 3 commits intoJun 30, 2026
Conversation
Model::__callStatic() forwarded unmatched static calls (select, orderBy, limit, ...) directly to the raw Query\Builder instead of ModelBuilder. Only the hand-written where() went through static::query(). As a result, Model::select(...) returned a builder with no knowledge of relations, breaking with() when chained after it (or after any other forwarded method).
…r loading
Adds ModelBuilder::with(), returning an EagerBuilder seeded with the
current underlying query (preserving any select/where/etc already
applied). Combined with the __callStatic fix, this makes with()
order-independent in the chain, matching the behaviour expected from
Eloquent-style ORMs (e.g. Laravel):
Page::select('id', 'slug')->with('translations')->where(...)->first();
Page::where(...)->with('translations')->select('id', 'slug')->first();
Previously with() only worked as the very first call via
Model::with().
Adds regression coverage for Model::select(...)->with(...) throwing "Call to unknown method: Foxdb\Query\Builder::with()", plus several chain-order variants (where->with->select, with->select->where), a with() constraint-closure case, and a guard confirming plain select() without with() is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.