Add playsinline to play video on iPhone#488
Add playsinline to play video on iPhone#488KaptenJansson merged 1 commit intowebrtc:masterfrom ptman:patch-1
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Damn, I tried, I really tried, to line all the ducks in a row. I amended the commit to show an email that I have signed the CLA for. I signed the CLA with both my work and private google accounts. Anything else I can do? |
|
No, as the googlebot comment eludes to you have reached a terminal state. But I can override it. Also the test failure is unrelated. |
re #486