Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

Add playsinline to play video on iPhone#488

Merged
KaptenJansson merged 1 commit intowebrtc:masterfrom
ptman:patch-1
Nov 13, 2017
Merged

Add playsinline to play video on iPhone#488
KaptenJansson merged 1 commit intowebrtc:masterfrom
ptman:patch-1

Conversation

@ptman
Copy link
Contributor

@ptman ptman commented Oct 5, 2017

re #486

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@ptman
Copy link
Contributor Author

ptman commented Oct 6, 2017

I signed it

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@ptman
Copy link
Contributor Author

ptman commented Oct 12, 2017

Damn, I tried, I really tried, to line all the ducks in a row. I amended the commit to show an email that I have signed the CLA for. I signed the CLA with both my work and private google accounts. Anything else I can do?

@KaptenJansson
Copy link
Contributor

No, as the googlebot comment eludes to you have reached a terminal state. But I can override it. Also the test failure is unrelated.

Copy link
Contributor

@KaptenJansson KaptenJansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaptenJansson KaptenJansson merged commit 86cc2cf into webrtc:master Nov 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants