Skip to content

trickle-ice: remove icecandidatepoolsize option #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2022
Merged

trickle-ice: remove icecandidatepoolsize option #1572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dd84ba
trickle-ice: remove icecandidatepoolsize option
fippo Sep 8, 2022
61e76e1
Merge branch 'gh-pages' into no-pool
fippo Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/content/peerconnection/trickle-ice/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,18 +101,11 @@ <h2>ICE options</h2>
<input type="radio" name="transports" value="relay" id="relay">
<span>relay</span>
</div>
<div>
<label>ICE Candidate Pool:</label>
<span id="poolValue">0</span>
<span class="gray">0</span>
<input id="iceCandidatePool" type="range" min="0" max="10" value="0">
<span class="gray">10</span>
</div>

</section>

<section>
<div>
<div>
<input type="checkbox" name="getUserMedia" id="getUserMedia">
<label for="getUserMedia"><span>Acquire microphone/camera permissions</span></label>
</div>
Expand Down
7 changes: 0 additions & 7 deletions src/content/peerconnection/trickle-ice/js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const resetButton = document.querySelector('button#reset');
const servers = document.querySelector('select#servers');
const urlInput = document.querySelector('input#url');
const usernameInput = document.querySelector('input#username');
const iceCandidatePoolInput = document.querySelector('input#iceCandidatePool');
const getUserMediaInput = document.querySelector('input#getUserMedia');

addButton.onclick = addServer;
Expand All @@ -30,11 +29,6 @@ resetButton.onclick = (e) => {
setDefaultServer(serversSelect);
};

iceCandidatePoolInput.onchange = (e) => {
const span = e.target.parentElement.querySelector('span');
span.textContent = e.target.value;
};

let begin;
let pc;
let stream;
Expand Down Expand Up @@ -148,7 +142,6 @@ async function start() {
const config = {
iceServers: iceServers,
iceTransportPolicy: iceTransports,
iceCandidatePoolSize: iceCandidatePoolInput.value
};

const offerOptions = {offerToReceiveAudio: 1};
Expand Down