Skip to content

Fix jest interop tests #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fippo merged 2 commits into from
Sep 20, 2023
Merged

Fix jest interop tests #1625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f912e75
Fix jest interop tests
fippo Sep 20, 2023
80bddeb
fix options.bver vs options.version confusion
fippo Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/interop-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ jobs:
- run: BROWSER=${{matrix.browserA}} BVER=${{matrix.bver}} ./node_modules/travis-multirunner/setup.sh
- run: BROWSER=${{matrix.browserB}} BVER=${{matrix.bver}} ./node_modules/travis-multirunner/setup.sh
- run: Xvfb :99 &
- run: BROWSER_A=${{matrix.browserA}} BROWSER_B=${{matrix.browserB}} BVER=${{matrix.bver}} DISPLAY=:99.0 node_modules/.bin/jest --retries=3 test/interop/connection.js
- run: BROWSER_A=${{matrix.browserA}} BROWSER_B=${{matrix.browserB}} BVER=${{matrix.bver}} DISPLAY=:99.0 node_modules/.bin/jest --retries=3 test/interop/
8 changes: 4 additions & 4 deletions test/interop/connection.js → test/interop/connection.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const browserB = process.env.BROWSER_B || 'chrome';
describe(`basic interop test ${browserA} => ${browserB}`, function() {
let drivers;
let clients;
before(async () => {
beforeAll(async () => {
const options = {
version: process.env.BVER || 'stable',
browserLogging: true,
Expand All @@ -31,7 +31,7 @@ describe(`basic interop test ${browserA} => ${browserB}`, function() {
};
});
});
after(async () => {
afterAll(async () => {
await drivers.map(driver => driver.close());
});

Expand All @@ -52,5 +52,5 @@ describe(`basic interop test ${browserA} => ${browserB}`, function() {

await steps.step(drivers, (d) => steps.waitNVideosExist(d, 1), 'Video elements exist');
await steps.step(drivers, steps.waitAllVideosHaveEnoughData, 'Video elements have enough data');
}).timeout(30000);
}).timeout(90000);;
}, 30000);
}, 90000);
4 changes: 2 additions & 2 deletions test/webdriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (os.platform() === 'win32') {
process.env.PATH += ':node_modules/.bin';
}

function buildDriver(browser = process.env.BROWSER || 'chrome', options = {bver: process.env.BVER}) {
function buildDriver(browser = process.env.BROWSER || 'chrome', options = {version: process.env.BVER}) {
// Chrome options.
const chromeOptions = new chrome.Options()
.addArguments('allow-insecure-localhost')
Expand Down Expand Up @@ -66,7 +66,7 @@ function buildDriver(browser = process.env.BROWSER || 'chrome', options = {bver:
}

const safariOptions = new safari.Options();
safariOptions.setTechnologyPreview(options.bver === 'unstable');
safariOptions.setTechnologyPreview(options.version === 'unstable');

// Firefox options.
const firefoxOptions = new firefox.Options();
Expand Down