Skip to content

Conversation

@teilzeitgeist
Copy link
Contributor

@teilzeitgeist teilzeitgeist commented Apr 11, 2019

see #128

@jukben
Copy link
Collaborator

jukben commented Apr 11, 2019

(bot)

Hey! Thank you so much for your PR! I can see that everything is green 👏.

Here is the playground for this revision 🚀

I hope everything is fine! ❤️

@jukben
Copy link
Collaborator

jukben commented Apr 11, 2019

Awesome, to see that boundariesElement works still like a charm. I would probably introduce another property renderToBody which does what you have here, otherwise I'll fallback to the original solution. What do you think about it? Are you willing to introduce the changes?

thank you for raising this! 🚀

@teilzeitgeist
Copy link
Contributor Author

Done 👍

@jukben
Copy link
Collaborator

jukben commented Apr 30, 2019

Hey I'm testing https://1026-94480675-gh.circle-artifacts.com/0/example/index.html but it looks like left position is not updated correctly (for example when you typing). Are you able to confirm it? Otherwise, thank you so far for pushing this!

+= instead of =+
@teilzeitgeist
Copy link
Contributor Author

Yeah ... my last change destroyed it 😅
The solution was simple: "+=" instead of "=+" 🤦‍♂

@jukben
Copy link
Collaborator

jukben commented Apr 30, 2019

Awesome, could you please add it also into docs (https://github.com/webscopeio/react-textarea-autocomplete#props). Right after textAreaComponent should be fine. Last thing and we are done! Thanks for the dope contribution! 🚀

adding documentation for the new prop "renderToBody"
Copy link
Collaborator

@jukben jukben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@jukben jukben merged commit bb28cae into webscopeio:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants