-
-
Notifications
You must be signed in to change notification settings - Fork 81
append suggestions dropdown in body #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
append suggestions dropdown in body #149
Conversation
|
(bot) Hey! Thank you so much for your PR! I can see that everything is green 👏. Here is the playground for this revision 🚀 I hope everything is fine! ❤️ |
|
Awesome, to see that thank you for raising this! 🚀 |
|
Done 👍 |
|
Hey I'm testing https://1026-94480675-gh.circle-artifacts.com/0/example/index.html but it looks like left position is not updated correctly (for example when you typing). Are you able to confirm it? Otherwise, thank you so far for pushing this! |
+= instead of =+
|
Yeah ... my last change destroyed it 😅 |
|
Awesome, could you please add it also into docs (https://github.com/webscopeio/react-textarea-autocomplete#props). Right after |
adding documentation for the new prop "renderToBody"
jukben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement!
see #128