(bug) background-image with double quotes

[mifi]

input:

<div style="width: 300px; height: 300px; background-image:url(&quot;https://via.placeholder.com/350x150&quot;)" class="image-background bg-image-1"></div>

output:

<div style="width: 300px; height: 300px; background-image:url("350x150")" class="image-background bg-image-1"></div>

it doesn't escape the double quotes, producing invalid HTML

[s0ph1e]

Hi @mifi

Thank you for reporting this issue 👍

Looks like it may be caused by bug in cheerio cheeriojs/cheerio#957
but can be fixed on website-scraper side in this place

node-website-scraper/lib/resource-handler/html/html-source-element.js

Lines 40 to 42 in 1155dde

	setData (newData) {
	this.rule.attr ? this.el.attr(this.rule.attr, newData) : this.el.text(newData);
	}

I'll take closer look on it later. Also contributions are welcome :)

[s0ph1e]

Hi @mifi 👋

Issue with double quotes is fixed in version 4.2.1

[mifi]

awesome, thanks