Enable fileNameGenerator byType to read Javscript files by mimeType. Curr…

[ykhandor]

Enable fileNameGenerator "byType" to read Javscript files by mimeType. Currently code only enables CSS and HTML files by mimeType.

[s0ph1e]

Thanks for contribution 👍

Could you please add small test for js extension, like we have for css and html here

node-website-scraper/test/unit/filename-generator/by-type-test.js

Lines 27 to 40 in 798a0f0

	it('should add missed extensions for html resources', function () {
	var r = new Resource('http://example.com/about', '');
	r.getType = sinon.stub().returns('html');
	var filename = byTypeFilenameGenerator(r, {}, []);
	filename.should.equalFileSystemPath('about.html');
	});
	it('should add missed extensions for css resources', function () {
	var r = new Resource('http://example.com/css', '');
	r.getType = sinon.stub().returns('css');
	var filename = byTypeFilenameGenerator(r, {}, []);
	filename.should.equalFileSystemPath('css.css');
	});

?

[s0ph1e]

I believe .min.js is not needed here, such files will have extension.js

[ykhandor]

Makes sense..will get rid of this one. I was not sure, I added it to be double sure and cover all bases.

[ykhandor]

Also, I will add the test for .js files and push the code up. You should have a new commit/PR to approve soon!

[ykhandor]

@s0ph1e : The updated code has been pushed and the new commit is in and ready for approval.

[s0ph1e]

Thanks @ykhandor
I will publish this changes in next release 3.3.4 today

[s0ph1e]

Released in version 3.3.5