Skip to content

fix config error in ExpressJS example#1137

Closed
nhaesler wants to merge 1 commit intowebsockets:masterfrom
nhaesler:patch-1
Closed

fix config error in ExpressJS example#1137
nhaesler wants to merge 1 commit intowebsockets:masterfrom
nhaesler:patch-1

Conversation

@nhaesler
Copy link
Copy Markdown

@nhaesler nhaesler commented Jun 9, 2017

Without this fix I get the following error when using the ExpressJS example:

/home/nico/src/warten/server/node_modules/ws/lib/WebSocketServer.js:63
      throw new TypeError('missing or invalid options');
      ^

TypeError: missing or invalid options
    at WebSocketServer (/home/nico/src/warten/server/node_modules/ws/lib/WebSocketServer.js:63:13)
    at Object.<anonymous> (/home/nico/src/warten/server/app.js:16:13)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.runMain (module.js:605:10)
    at run (bootstrap_node.js:427:7)
    at startup (bootstrap_node.js:151:9)

@lpinca
Copy link
Copy Markdown
Member

lpinca commented Jun 9, 2017

Sorry but I see no reason to merge this. The example already uses const and shorthand property names are supported in Node.js 4 which is our lowest supported version.

@lpinca lpinca closed this Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants