add stub dispatchEvent method to WebSocket (#1583)#1584
add stub dispatchEvent method to WebSocket (#1583)#1584lpinca merged 1 commit intowebsockets:masterfrom brainkim:dispatchEvent
Conversation
|
You probably want to include a test to ensure that they are not removed in future refactors |
|
Added test and updated error message |
|
tests are hanging one sec |
|
Thank you. |
|
Thanks for the quick turnaround! May I leave the related issue open until I get a @types/ws definitions updated? |
|
Never mind. I’m looking into the typings now and there are way more incompatibilities between the ws WebSocket type and the typescript lib WebSocket type 😓 including but not limited to the |
|
Hmm ok then I think it's better to revert this as well. |
|
15 min passed so I guess it's ok to force push. On my way. |
|
Yeah if supporting the typescript websocket definition is desired, then I think supporting the Event/EventTarget interface more fully is required and I’m not sure if that’s what this project wants. Sorry for this. |
|
No problem. |
@types/wsto include the dispatchEvent method