Move completeUpgrade to WebSocketServer.prototype#897
Merged
Conversation
69e62df to
703986f
Compare
703986f to
40291cb
Compare
Member
|
Things are breaking :9 |
Member
Author
|
It's coveralls which is drunk, tests pass :) |
Member
|
@lpinca Yeah, I guess it complains when coverage gets reduced somehow. |
Member
Author
|
master branch (before merge) this branch kinda weird as coverage is exactly the same. |
Member
|
Well, the statements, branches and lines have less coverage in this branch. |
Member
|
But what ever, it's not that important. |
Member
Author
|
If you compare it with the total statements it's the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the following changes:
upgradefunction intoWebSocketServer.prototype.handleUpgrade().completeUpgradefromupgradeand add it toWebSocketServer.prototype.