Change Sender.prototype.frameAndSend() signature#933
Merged
Conversation
Member
Author
|
@websockets/admin LGTY? |
|
You should also update the sender benchmark with the new signature. |
Member
Author
|
Oh right, thanks for pointing that out, on my way. |
lpinca
force-pushed
the
use/options-object
branch
from
3fbdf79 to
b9b043a
Compare
lpinca
force-pushed
the
use/options-object
branch
from
b9b043a to
2dd4156
Compare
Member
Author
|
I'll merge this later today if there are no objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the signature of the
frameAndSendmethod to make it accept an options object.This should make it easier to add more options in future without having to add more arguments and remember their position.