Add null sorting

[manderj]

Hey 👋

I would like to contribute,
I had to make some changes for work and think it would be nice to have it merged.
the changes are quite simple and just consists of allowing sorting by null values (in first or last position) on the selected column.
I'll gladly answer any question

[stephane]

@manderj Could you submit another patch to handle nulls=first or nulls=last to avoid complexity that ensure current nulls_last=True and nulls_first=True are exclusives?

Another solution, would be to only handle nulls_first=True|False and to left it undefined when not set.
I think I prefer this solution.

By default, b-tree index of PostgreSQL uses nulls last but I think it's important to not explicitly set an ordering of null as you did.

[manderj]

@manderj Could you submit another patch to handle nulls=first or nulls=last to avoid complexity that ensure current nulls_last=True and nulls_first=True are exclusives?

Another solution, would be to only handle nulls_first=True|False and to left it undefined when not set.
I think I prefer this solution.

By default, b-tree index of PostgreSQL uses nulls last but I think it's important to not explicitly set an ordering of null as you did.

Okay 👍, I'll seen into that later today and will make a new pull request when I'm done 🙂
Thanks for the fast answer!

[stephane]

Any news?

[manderj]

Hey, sorry I didn't make any update.
I'm currently hospitalized, whenever I'll be out I'll make the changes.
I'm every sorry for the inconveniences.

[stephane]

Oh, don't worry. I hope you're fine, take time to recover.
Health is more important than code ;)