feat: support css variables in shadow properties #5032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added css variables support with autocomplete in text-shadow and box-shadow properties. Extended our ast with new "shadow" value to properly represent variables in shadow poperties.
kof
approved these changes
Mar 25, 2025
Member
kof
left a comment
kof
left a comment
There was a problem hiding this comment.
discussed that we separately fix editing code area with variables: when it happens we replace fields with computed values as soon as user tries to edit the shadow with variables inside
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4939
Added css variables support with autocomplete in text-shadow and box-shadow properties.
Extended our ast with new "shadow" value to properly represent variables in shadow properties. Though parser still cannot extract variables from value with variables and falls back to "unparsed" value.