fixed cp command still calling webui-2 instead of libwebui-2 in "minimal" #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing fail on program start since upstream switched on nightly.
hassandraga
approved these changes
Mar 26, 2025
Member
|
Thank you @SageCreations for the fix. |
Member
|
Indeed, Linux and macOS both now use macOS: Linux: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you start a new project on Linux specifically in my case, "minimal" for the bootstrap runs and fails because the copy command still has "webui-2.so" as the file rather "libwebui-2.so" that nightly now uses.
So far every time I run on MacOS option 1 in the script runs so it renames the contents to webui-2.dylib but if it were to run with the "minimal" argument, it would have the same the problem I see on Linux.
This was the only line I had to change to make my program run (besides from the commits that have already been made) and double checked on MacOS to see why it was still working. I believe this is the only thing needed. We should prep/push for next release to fix the PyPi release soon.