Array too small (MAX_BROWSER_FILES) #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAX_BROWSER_FILES needed to be 5. Also initialized all array entries to NULL before assigning executable names. Signed-off-by: Hans Dijkema <hans@dijkewijk.nl>
Signed-off-by: Hans Dijkema <hans@dijkewijk.nl>
Removed unnecessary initialization loop for executables array.
AlbertShown
approved these changes
Oct 20, 2025
Contributor
Author
|
Nice, after so many years of C/C++ programming I still didn't know that char *a[N] = { 0 } will initialize the complete array to 0. |
Member
|
Yes, it's a standard ANSI C since 1999 👍 |
Contributor
Author
|
Working with C since 1988 😖 |
Member
|
That's totally fine, and thank you @hdijkema for your recent fixes and improvements 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed problem with array allocation for executables array.
MAX_BROWSER_FILES needed to be 5. Also initialized all
array entries to NULL before assigning executable names.