Skip to content

Conversation

@feifei325
Copy link
Collaborator

@feifei325 feifei325 commented Oct 29, 2025

chore(docker-compose): update config values and add timezone:

  • increase ACCESS_TOKEN_EXPIRE_MINUTES from 30 to 10080 (7 days)
  • add APPEND_TASK_EXPIRE_HOURS and SUBTASK_EXECUTOR_DELETE_AFTER_HOURS
  • set TZ=Asia/Shanghai for executor_manager service

Summary by CodeRabbit

  • Chores
    • Extended access token expiration duration, allowing longer session persistence.
    • Added task expiration timeout configuration for improved resource management.
    • Added subtask executor cleanup timeout settings.
    • Added timezone configuration support for the task executor service.

@coderabbitai
Copy link

coderabbitai bot commented Oct 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Environment variable modifications in docker-compose.yml: ACCESS_TOKEN_EXPIRE_MINUTES increased from 30 to 10080 minutes, new task expiration settings added (APPEND_TASK_EXPIRE_HOURS and SUBTASK_EXECUTOR_DELETE_AFTER_HOURS both set to 2), and timezone configuration added to executor_manager.

Changes

Cohort / File(s) Summary
Docker Compose Configuration
docker-compose.yml
Modified backend ACCESS_TOKEN_EXPIRE_MINUTES from 30 to 10080; added APPEND_TASK_EXPIRE_HOURS and SUBTASK_EXECUTOR_DELETE_AFTER_HOURS (both 2 hours); added TZ: Asia/Shanghai to executor_manager

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • These are straightforward environment variable configuration changes with no logic modifications or behavioral complexity.

Poem

🐰 With minutes extended and timezones set,
The config now dances, no need to fret!
Shanghai's time flows, tasks expire on cue,
Ten thousand minutes of tokens brand new!

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-docker-compose-config

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bde4026 and f0ce181.

📒 Files selected for processing (1)
  • docker-compose.yml (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@feifei325 feifei325 merged commit f0b729e into main Oct 29, 2025
1 check was pending
@qdaxb qdaxb deleted the chore/update-docker-compose-config branch October 30, 2025 06:12
Micro66 added a commit that referenced this pull request Nov 19, 2025
…PATH

Critical fixes for local development setup:

1. **Project root directory requirement**:
   - All operations must be run from project root (Wegent/), not executor subdirectory
   - Updated all path references and commands to reflect this requirement
   - Added prominent warning at the beginning of setup instructions

2. **PYTHONPATH configuration**:
   - Added mandatory PYTHONPATH setup: `export PYTHONPATH=$(pwd)`
   - Included in all startup instructions and quick start script
   - Added to troubleshooting section with specific error examples

3. **Updated quick start script**:
   - Changed from executor/ directory to project root
   - Auto-detects script location and navigates to project root
   - Sets PYTHONPATH before starting service
   - Corrected dependency installation path to executor/requirements.txt

4. **Enhanced troubleshooting**:
   - Added FAQ for PYTHONPATH not set (FAQ #5)
   - Added FAQ for running in wrong directory (FAQ #6)
   - Updated virtual environment FAQ with correct paths

5. **Improved clarity**:
   - Added warning boxes highlighting critical requirements
   - Updated all code examples to show correct directory context
   - Emphasized PYTHONPATH requirement throughout documentation

These changes address module import errors that occur when PYTHONPATH is not properly configured or when running from the wrong directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants