Skip to content

Upgrade flags dependency (#87)#88

Merged
nico2che merged 1 commit intomasterfrom
feature/87-upgrade-flags-dependency
Sep 2, 2025
Merged

Upgrade flags dependency (#87)#88
nico2che merged 1 commit intomasterfrom
feature/87-upgrade-flags-dependency

Conversation

@nico2che
Copy link
Copy Markdown
Member

@nico2che nico2che commented Sep 2, 2025

Close #87

  • migrate flag-icon-css to flag-icons
  • add copy-svg script to only get used flags from languages.json
  • use new flags (es-ct and es-pv)
  • minify svgs during build

@nico2che nico2che force-pushed the feature/87-upgrade-flags-dependency branch 3 times, most recently from a0e4c47 to 4a33a8d Compare September 2, 2025 13:13
@nico2che nico2che force-pushed the feature/87-upgrade-flags-dependency branch from 4a33a8d to ef58007 Compare September 2, 2025 13:17
Comment thread bin/copySvg.js
fs.copyFileSync(sourceFlag, outputFlag);
continue;
}
if (!fs.existsSync(outputFlag)) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a également un test unitaire

test('All flag codes exist', () => {
const countryFlagCodes = languages.map((language) => language.country_flag_code);
(new Set(countryFlagCodes)).forEach(function (countryFlagCode) {
expect(fs.existsSync(`${__dirname}/../images/1x1/${countryFlagCode}.svg`)).toBe(true);
expect(fs.existsSync(`${__dirname}/../images/4x3/${countryFlagCode}.svg`)).toBe(true);
})
});

Mais ça fait pas de mal de le checker dans le script 👍

@nico2che nico2che merged commit 5b1785d into master Sep 2, 2025
2 checks passed
@nico2che nico2che deleted the feature/87-upgrade-flags-dependency branch September 2, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saudi Arabia flag

2 participants