Merged
Conversation
VincentLanglet
force-pushed
the
commitPhp
branch
from
007c9dd to
2dc965d
Compare
VincentLanglet
force-pushed
the
commitPhp
branch
from
e578029 to
9a91a92
Compare
floranpagliai
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
En installant languages via composer, le dossier dist n'est pas build.
Du coup on a pas accès aux classes PHP et on y perds tout l'intérêt...
Coté weglot/platform on est obligé de relire le json
https://github.com/weglot/platform/blob/647d6621afae82a8c52ad11471b67ccecd04d24c/engine/src/Command/ImportLanguagesCommand.php#L77
Si on commit les classes PHP, elles seront installées avec composer.
Qu'en pensez vous @EtienneDh @floranpagliai