Skip to content

[feat] Tutorial#28

Merged
5 commits merged intomainfrom
Tutorial-GUI
Jan 22, 2022
Merged

[feat] Tutorial#28
5 commits merged intomainfrom
Tutorial-GUI

Conversation

@ghost
Copy link

@ghost ghost commented Jan 20, 2022

Stabile Nummer auf Basic Niveau xd
giphy

Copy link
Member

@weichbot10 weichbot10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

checkstyle

src/main/java/github/weichware10/toolbox/gui/Tutorial.java|89 col 66| WhitespaceAround: '+' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
src/main/java/github/weichware10/toolbox/gui/Tutorial.java|89 col 66| WhitespaceAround: '+' is not preceded with whitespace.
src/main/java/github/weichware10/toolbox/gui/Tutorial.java|96 col 5| Missing a Javadoc comment.
src/main/java/github/weichware10/toolbox/gui/Tutorial.java|97 col 9| 'if' is not followed by whitespace.
src/main/java/github/weichware10/toolbox/gui/Tutorial.java|97 col 9| WhitespaceAround: 'if' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
src/main/java/github/weichware10/toolbox/gui/Tutorial.java|99 col 9| '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
src/main/java/github/weichware10/toolbox/gui/Tutorial.java|100 col 14| 'if' is not followed by whitespace.
src/main/java/github/weichware10/toolbox/gui/Tutorial.java|100 col 14| WhitespaceAround: 'if' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
src/main/java/github/weichware10/toolbox/gui/TutorialController.java|8 col 1| Wrong lexicographical order for 'javafx.scene.image.ImageView' import. Should be before 'javafx.scene.layout.HBox'.
src/main/java/github/weichware10/toolbox/gui/TutorialController.java|11 col 1| Missing a Javadoc comment.
src/main/java/github/weichware10/toolbox/gui/TutorialController.java|25 col 18| Member name 'hBoxId' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$' (camelCase, start with lowercase, only alphanumerical).
src/main/java/github/weichware10/toolbox/gui/TutorialController.java|74| Line is longer than 100 characters (found 117).
src/main/java/github/weichware10/toolbox/gui/TutorialController.java|75| Line is longer than 100 characters (found 107).
src/main/java/github/weichware10/toolbox/gui/TutorialController.java|76| Line is longer than 100 characters (found 119).
src/main/java/github/weichware10/toolbox/gui/TutorialController.java|77| Line is longer than 100 characters (found 119).
src/main/java/github/weichware10/toolbox/gui/TutorialController.java|78| Line is longer than 100 characters (found 123).
src/main/java/github/weichware10/toolbox/gui/TutorialController.java|79| Line is longer than 100 characters (found 123).

@ghost ghost added the enhancement New feature or request label Jan 21, 2022
@ghost ghost self-assigned this Jan 21, 2022
@joshuajeschek joshuajeschek changed the title [function] Tutorial [feat] Tutorial Jan 21, 2022
@joshuajeschek
Copy link
Member

Danke für deine Arbeit, ich würde das so anpassen, dass das Tutorial vor dem PreTest gezeigt wird :D

Border um Bilder
Anzeigezeitpunkt verändert
@joshuajeschek
Copy link
Member

okay wow ich hatte mal wieder vergessen zu pushen xd
@TheDarkDesync kannst du nochmal drüberschauen?

Copy link
Member

@philipkbh philipkbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it

@ghost ghost merged commit 2efb04d into main Jan 22, 2022
@ghost ghost deleted the Tutorial-GUI branch January 22, 2022 17:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants