Conversation
In REF, the zero column check should only check below the completed rows. The check was done for the whole column, so columns like [1 0 0 0] where the first row has been fixed while working on the previous column would trigger the 500 error.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/weiseng18/math/9fYSLADSUrPsXWLyiyfzUpmPvB3S |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In REF, the zero column check should only check below the completed rows. The
check was done for the whole column, so columns like [1 0 0 0] where the
first row has been fixed while working on the previous column would trigger
the 500 error.
Solution
Update the zero column check
Checklist
develop, merge locallydevelopandmaster, dogit diff --stat masterwhile indevelopbranch. Ensure that the diff is not too largeNotes