Skip to content

fix: logic did not exclude the completed rows#29

Merged
weiseng18 merged 1 commit intodevelopfrom
fix/rref
Aug 8, 2021
Merged

fix: logic did not exclude the completed rows#29
weiseng18 merged 1 commit intodevelopfrom
fix/rref

Conversation

@weiseng18
Copy link
Copy Markdown
Owner

@weiseng18 weiseng18 commented Aug 8, 2021

Problem

In REF, the zero column check should only check below the completed rows. The
check was done for the whole column, so columns like [1 0 0 0] where the
first row has been fixed while working on the previous column would trigger
the 500 error.

Solution

Update the zero column check

Checklist

  • If the branch was not created off latest develop, merge locally
  • Using latest develop and master, do git diff --stat master while in develop branch. Ensure that the diff is not too large

Notes

In REF, the zero column check should only check below the completed rows. The
check was done for the whole column, so columns like [1 0 0 0] where the
first row has been fixed while working on the previous column would trigger
the 500 error.
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/weiseng18/math/9fYSLADSUrPsXWLyiyfzUpmPvB3S
✅ Preview: https://math-git-fix-rref-weiseng18.vercel.app

@weiseng18 weiseng18 merged commit ead7188 into develop Aug 8, 2021
@weiseng18 weiseng18 deleted the fix/rref branch August 8, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant