Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/weiseng18/math/EnR8QkjFpYUrPXQvXWjMNLczQNpV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
throw new Errorwas previously used, so all errors are500. In the two locations it is used, a400should be thrown instead./matrixwas not able to access the actual custom error message, instead it just saysRequest failed with status code 500Solution
HttpExceptionclass that accepts a status code to throw non-500 errors easily, and update the two locations to throw a400instead.err.response.data.message, and noterr.message. Update the lineChecklist
develop, merge locallydevelopandmaster, dogit diff --stat masterwhile indevelopbranch. Ensure that the diff is not too largeNotes
Considered writing a middleware to handle the errors, but that would require
next()which is not part of Vercel's serverless functions structure. I could usenext: Function, and it would work as expected. However, the API tests usevercel-node-server, which is not able to triggernext(), and rightfully so since it is not part of Vercel's serverless functions structure.