Skip to content

Fix/rendering#51

Merged
weiseng18 merged 3 commits intodevelopfrom
fix/rendering
Aug 16, 2021
Merged

Fix/rendering#51
weiseng18 merged 3 commits intodevelopfrom
fix/rendering

Conversation

@weiseng18
Copy link
Copy Markdown
Owner

@weiseng18 weiseng18 commented Aug 16, 2021

Problem

On a page with a loaded query, triggering a second query will still show remnants of the previous query.

Solution

  • Give passedQuery higher priority than query
  • Add key to table, to trigger re-render (on /logic page)
  • Reset all states when clearing data

Checklist

  • If the branch was not created off latest develop, merge locally
  • Using latest develop and master, do git diff --stat master while in develop branch. Ensure that the diff is not too large
  • If this is a feature, has appropriate documentation been added?

Notes

Back/forward still does not work as intended. Issue filed #52

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/weiseng18/math/HMShP43iuzCqdbTnc9Mzz6SFmhtx
✅ Preview: https://math-git-fix-rendering-weiseng18.vercel.app

@weiseng18 weiseng18 merged commit e04f9aa into develop Aug 16, 2021
@weiseng18 weiseng18 deleted the fix/rendering branch August 16, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant